xuefuz commented on a change in pull request #9239: [FLINK-13385]Align Hive
data type mapping with FLIP-37
URL: https://github.com/apache/flink/pull/9239#discussion_r307832232
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogDataTypeTest.java
##########
@@ -124,8 +122,8 @@ public void testDataTypes() throws Exception {
@Test
public void testNonExactlyMatchedDataTypes() throws Exception {
Review comment:
Maybe we should change this test to a negative test case, as BINARY and
VARBINARY are not supported by hive and it's useful to capture the limitation
with a test case.
Also, we may change the method name accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
