[ 
https://issues.apache.org/jira/browse/FLINK-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908086#comment-14908086
 ] 

ASF GitHub Bot commented on FLINK-2576:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1138#discussion_r40434856
  
    --- Diff: 
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/MatchNode.java ---
    @@ -22,15 +22,16 @@
     import java.util.Collections;
     import java.util.List;
     
    +import org.apache.flink.api.common.operators.base.AbstractJoinOperatorBase;
     import org.apache.flink.api.common.operators.base.JoinOperatorBase;
    -import 
org.apache.flink.api.common.operators.base.JoinOperatorBase.JoinHint;
    +import 
org.apache.flink.api.common.operators.base.AbstractJoinOperatorBase.JoinHint;
     import org.apache.flink.optimizer.CompilerException;
     import org.apache.flink.optimizer.DataStatistics;
     import org.apache.flink.optimizer.Optimizer;
     import org.apache.flink.optimizer.operators.HashJoinBuildFirstProperties;
     import org.apache.flink.optimizer.operators.HashJoinBuildSecondProperties;
     import org.apache.flink.optimizer.operators.OperatorDescriptorDual;
    -import org.apache.flink.optimizer.operators.SortMergeJoinDescriptor;
    --- End diff --
    
    You completely remove the `MatchNode`. It is not referenced in the source 
code.


> Add outer joins to API and Optimizer
> ------------------------------------
>
>                 Key: FLINK-2576
>                 URL: https://issues.apache.org/jira/browse/FLINK-2576
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Java API, Optimizer, Scala API
>            Reporter: Ricky Pogalz
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Add left/right/full outer join methods to the DataSet APIs (Java, Scala) and 
> to the optimizer of Flink.
> Initially, the execution strategy should be a sort-merge outer join 
> (FLINK-2105) but can later be extended to hash joins for left/right outer 
> joins.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to