[ 
https://issues.apache.org/jira/browse/FLINK-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16890783#comment-16890783
 ] 

TisonKun commented on FLINK-13370:
----------------------------------

[~matt.lloyd] 2 questions here.

1. What if custom CuratorFramework incompatible with codes inside Flink based 
on Curator? FLINK-8660 customizes the whole HAService and all based on 
interfaces Flink provided so it won't suffer from this issue.

2. What's worse, Flink uses a shaded version of curator(see 
flink-shaded-curator) and I am afraid that any custom CuratorFramework is 
incompatible.

> Allow Custom CuratorFramework
> -----------------------------
>
>                 Key: FLINK-13370
>                 URL: https://issues.apache.org/jira/browse/FLINK-13370
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: Matt Lloyd
>            Priority: Major
>
> Due to how the CuratorFrameworkFactory is implemented in Flink, I am unable 
> to use it with my existing Zookeeper clusters which rely on custom 
> authentication.
> To allow for this situation, I propose making the following changes to allow 
> users to pass in custom factory methods (in a similar vein to FLINK-8660).
>  * Create {{FlinkCuratorFactory}} interface
>  * Move the current [CuratorFramework factory 
> method|[https://github.com/apache/flink/blob/11a8234b50586d476371c64f9d751e8e65fdad0a/flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java#L73]]
>  into a Factory class that implements the {{FlinkCuratorFactory}} interface
>  * Add new config {{zookeeper.curator.factory}} that defaults to the current 
> implementation or takes the FQN of a user defined factory
>  * Replace the existing [CuratorFramework factory 
> method|[https://github.com/apache/flink/blob/11a8234b50586d476371c64f9d751e8e65fdad0a/flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java#L73]]
>  to uses the {{zookeeper.curator.factory}} config to call the appropriate 
> factory.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to