[ 
https://issues.apache.org/jira/browse/FLINK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906067#comment-14906067
 ] 

ASF GitHub Bot commented on FLINK-2751:
---------------------------------------

Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1176#issuecomment-142863133
  
    Hi @rerngvit, Thanks for sending pull request. But your pull request has 
some problems.
    
    First, `{{ quickstart }}` is not defined in your changes. As you can see in 
19-22 lines of `navbar.html`, you should define `{{ quickstart }}`.
    
    Second, there is no conditional `active` class for quickstart dropdown 
menu. Please include conditional `active` class in quickstart dropdown menu. 
Conditional `active` classes for other menus are in line 55 of `navbar.html`.


> Quickstart is in documentation but only linked through the Flink homepage
> -------------------------------------------------------------------------
>
>                 Key: FLINK-2751
>                 URL: https://issues.apache.org/jira/browse/FLINK-2751
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 0.9, 0.10
>            Reporter: Maximilian Michels
>              Labels: starter
>             Fix For: 0.9, 0.10
>
>
> The Quickstart docs contained in {{docs/quickstart}} should also be included 
> in the documentation menu. Basically, we could copy over the Quickstart menu 
> from the Flink homepage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to