xuefuz commented on issue #9172: [FLINK-13313][table] create CatalogTableBuilder to support building CatalogTable from descriptors URL: https://github.com/apache/flink/pull/9172#issuecomment-513402576 Keeping the name unchanged is fine to me. However, I don't expect that we will use this builder to build Hive CatalogTable. That builder probably will reside in Hive connector package rather than here. Therefore, I don't think we even need to have a member variable "isGeneric" in CatalogTableBuilder. Putting it here might give a misconception. This is a minor issue, though. Otherwise, the PR looks good to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
