bowenli86 commented on a change in pull request #9049: [FLINK-13176][SQL CLI] 
remember current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#discussion_r305014586
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
 ##########
 @@ -232,7 +238,10 @@ public void useCatalog(SessionContext session, String 
catalogName) throws SqlExe
                        .getTableEnvironment();
 
 Review comment:
   @twalthr can you elaborate a bit more? AFAICT, 
`org.apache.flink.table.client.gateway.local.LocalExecutor#validateSession` 
seems only to be responsible for creating an execution context, but cannot set 
any current catalog and current database?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to