xintongsong commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r304906357
##########
File path:
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerTest.java
##########
@@ -829,4 +839,45 @@ public void testClearStateAfterRevokeLeadership() throws
Exception {
verify(rmServices.schedulerDriver).stop(true);
}};
}
+
+ /**
+ * Tests that RM and TM calculate same slot resource profile.
+ */
+ @Test
+ public void testCreateSlotsPerWorker() throws Exception {
Review comment:
Thank you for the suggestion, @GJL. I think this does solve the problem. In
that case we should also move `slotsPerWorker` to the common base class
ResourceManager, which may not be used by StandaloneResourceManager but still
can be shared by Yarn/Mesos/Kubernetes ResourceManagers. I'll make an update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
