KurtYoung commented on a change in pull request #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner URL: https://github.com/apache/flink/pull/8962#discussion_r301980036
########## File path: flink-table/flink-table-planner-blink/pom.xml ########## @@ -150,24 +150,29 @@ under the License. <groupId>org.apache.calcite</groupId> <artifactId>calcite-core</artifactId> <!-- When updating the Calcite version, make sure to update the dependency exclusions --> - <version>1.19.0</version> + <version>1.20.0</version> <exclusions> <!-- - - Dependencies that are not needed for how we use Calcite right now. - - "mvn dependency:tree" as of Calcite 1.19: - - [INFO] +- org.apache.calcite:calcite-core:jar:1.19.0:compile - [INFO] | +- org.apache.calcite.avatica:avatica-core:jar:1.13.0:compile - [INFO] | +- org.apache.calcite:calcite-linq4j:jar:1.19.0:compile - [INFO] | +- org.apache.commons:commons-lang3:jar:3.3.2:compile - [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.9.6:compile - [INFO] | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.6:compile - [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.6:compile + "mvn dependency:tree" as of Calcite 1.20: Review comment: This list should reflect all compile dependency, I'm quite doubt for dependency like "net.hydromatic:aggdesigner-algorithm" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services