dawidwys commented on a change in pull request #8874:
[FLINK-12968][table-common] Add a utility for logical type casts
URL: https://github.com/apache/flink/pull/8874#discussion_r298496771
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInferenceUtil.java
##########
@@ -206,7 +207,9 @@ private static AdaptedCallContext adaptArguments(
}
private static boolean canCast(DataType sourceDataType, DataType
targetDataType) {
Review comment:
nit: should we add a flag what kind of cast is it? Similarly as calcite does?
```
private static boolean canCast(DataType sourceDataType, DataType
targetDataType, boolean coerce?) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
