bowenli86 commented on a change in pull request #8920: [FLINK-13024][table] integrate FunctionCatalog with CatalogManager URL: https://github.com/apache/flink/pull/8920#discussion_r298404869
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/logical/PushFilterIntoTableSourceScanRule.scala ########## @@ -68,7 +68,7 @@ class PushFilterIntoTableSourceScanRule extends RelOptRule( RexProgramExtractor.extractConjunctiveConditions( program, call.builder().getRexBuilder, - new FunctionCatalog("default_catalog", "default_database")) + new FunctionCatalog(null)) Review comment: are we able to pass in CatalogManager here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services