bowenli86 commented on a change in pull request #8636:
[FLINK-12237][hive]Support Hive table stats related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8636#discussion_r298296277
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV1.java
##########
@@ -95,4 +97,12 @@ public boolean moveToTrash(FileSystem fs, Path path,
Configuration conf, boolean
throw new IOException("Failed to move " + path + " to
trash", e);
}
}
+
+ @Override
+ public void alterTable(IMetaStoreClient client, String databaseName,
String tableName, Table table) throws InvalidOperationException, MetaException,
TException {
+ // For Hive-1.2.1, we need to tell HMS not to update stats.
Otherwise, the stats we put in the table
Review comment:
Nice!
Can you also add comments to explain how Hive-2.3.4 handles it too? Will
Hive 2.3.4 just not update any table stats in parameters when
client.alter_table is invoked?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
