mans2singh edited a comment on issue #8668: [FLINK-12784][metrics] Support 
retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#issuecomment-506077097
 
 
   @NicoK - 
   
   Thanks for your review. 
   
   I've updated the code and documentation based on your feedback.  One note 
that for the retention policy, the request parameter key in [test 
case](https://github.com/apache/flink/pull/8668/files#diff-4ab6d3fdde78854f34e1006ee8335812R115)
 is 'rp' as required by InfluxDB even though the property name is 
'retentionPolicy' for usability. 
   
   Please let me know if you have other recommendations and if I can resolve 
the comments.
   
   Thanks again for your time.
   
   Mans

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to