zentol commented on a change in pull request #8646: [FLINK-12735][network] Make
shuffle environment implementation independent with IOManager
URL: https://github.com/apache/flink/pull/8646#discussion_r297569347
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactory.java
##########
@@ -149,16 +150,15 @@ private void createSubpartitions(
}
}
- private static void initializeBoundedBlockingPartitions(
+ private void initializeBoundedBlockingPartitions(
ResultSubpartition[] subpartitions,
- ResultPartition parent,
- IOManager ioManager) {
Review comment:
couldn't you pass in the channelManager instead and keep it static?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
