1u0 commented on a change in pull request #8692: [FLINK-12804] Introduce 
mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r296695848
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
 ##########
 @@ -123,14 +124,12 @@ protected void performDefaultAction(ActionContext 
context) throws Exception {
                context.allActionsCompleted();
        }
 
-       private void runAlternativeMailboxLoop() throws InterruptedException {
+       private void runAlternativeMailboxLoop() throws InterruptedException, 
MailboxStateException {
 
-               while (true) {
+               final Mailbox mailbox = taskMailboxExecutor.getMailbox();
 
 Review comment:
   @StefanRRichter, the patch for tests: #8858

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to