azagrebin commented on a change in pull request #8824: [FLINK-12923][runtime] 
Introduce Task termination future
URL: https://github.com/apache/flink/pull/8824#discussion_r296237295
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -509,317 +516,309 @@ public void startTaskThread() {
         */
        @Override
        public void run() {
+               try {
 
 Review comment:
   ```
   @Override
   public void run() {
       try {
           doRun();
       } finally {
            terminationFuture.complete(executionState);
       }
   }
   
   private void doRun() {
       // .... what we have in run now
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to