becketqin commented on issue #6594: [FLINK-9311] [pubsub] Added PubSub source 
connector with support for checkpointing (ATLEAST_ONCE)
URL: https://github.com/apache/flink/pull/6594#issuecomment-504332708
 
 
   @Xeli It is great to hear that you've got the connector working in 
production. Thanks for letting us know. Do you know how much is your latest 
version differ from the current code in the PR? If it is not a big diff, say 
less 200 or 300 lines of code change, I can take a quick review and hopefully 
there won't be much concerns. But if the diff is huge, we may as well fix the 
test in the current PR and do a separate PR to get your latest code. What do 
you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to