Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-140375020
I thinks it should be fine. The `TaskOperationResult` should only indicate,
that the signal was delivered successful (ie, only sent to "streaming
sources"). All other operators would raise an exception. If the user did not
implements `stop()` just nothing should happen... (at least from my point of
view -- "stop" is only a request and the Source must no obey it -- in contrast
to cancel). If this does not match the opinion of the majority, we can of
course change it. (We would not need an additional task thread if we use a
future, right?)
In order to see possible exceptions, I just added an additional try-catch
around `SourceFunction.stop()` to log them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
