c4emmmm commented on issue #8632: [FLINK-12744][ml] add shared params in ml package URL: https://github.com/apache/flink/pull/8632#issuecomment-502573646 I suggest to move the modification of Params and ParamInfo which are in the flink-ml-api module to another PR and leaving only param definition interfaces here. It follows the contributing instruction better and is indeed clearer. Since the param definition interfaces are not affected by the modification, I think it's ok to move and then merge them separately. What do you think about it? @walterddr @ex00 @shaomengwang @xuyang1706 @becketqin
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
