godfreyhe commented on a change in pull request #8736: [FLINK-12846][table]
Carry primary key and unique key information in TableSchema
URL: https://github.com/apache/flink/pull/8736#discussion_r294120943
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/util/TableTestBase.scala
##########
@@ -147,13 +161,15 @@ abstract class TableTestUtil(test: TableTestBase) {
* @param types field types
* @param fields field names
* @param statistic statistic of current table
+ * @param uniqueKeys unique keys of current table
* @return returns the registered [[Table]].
*/
def addTableSource(
name: String,
types: Array[TypeInformation[_]],
fields: Array[String],
- statistic: FlinkStatistic = FlinkStatistic.UNKNOWN): Table
+ statistic: TableStats,
Review comment:
we may add more info for `FlinkStatistic`, use `FlinkStatistic` instead of
each fields to make sure this method and related test cases are stable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
