JingsongLi commented on issue #8682: [FLINK-12796][table-planner-blink] 
Introduce BaseArray and BaseMap to reduce conversion overhead to blink
URL: https://github.com/apache/flink/pull/8682#issuecomment-501973780
 
 
   > Can you please provide the benchmark that produces the 10x performance 
improvement?
   
   You can find the case in `SortAggITCase.testBigDataSimpleArrayUDAF`.
   If you want to test previous code, you can modify 
`PrimitiveLongArrayConverter.toInternalImpl` to use `return 
BinaryArray.fromPrimitiveArray(value);`.
   The difference is so obvious, both in generated code and performance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to