xuefuz commented on a change in pull request #8720: [FLINK-12771][hive] Support 
ConnectorCatalogTable in HiveCatalog
URL: https://github.com/apache/flink/pull/8720#discussion_r293573354
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
 ##########
 @@ -313,6 +327,20 @@ public void createTable(ObjectPath tablePath, 
CatalogBaseTable table, boolean ig
                        throw new DatabaseNotExistException(getName(), 
tablePath.getDatabaseName());
                }
 
+               if (table instanceof ConnectorCatalogTable) {
+                       ConnectorCatalogTable connectorTable = 
connectorTables.get(tablePath);
+
+                       if (connectorTable != null && 
!tableExistsInHiveMetastore(tablePath)) {
 
 Review comment:
   Why cannot we just call tableExists()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to