zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293332653
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -381,17 +383,20 @@ void onConsumedSubpartition(int subpartitionIndex) {
return;
}
- int refCnt = pendingReferences.decrementAndGet();
-
- if (refCnt == 0) {
+ if (isManagedExternally) {
partitionManager.onConsumedPartition(this);
Review comment:
TBH I do not like the current way because it seems a bit hacky.
Because during `ResultPartition#onConsumedSubpartition`, the counter would
never be 0 for external case, so the
`ResultPartitionManager#onConsumedPartition` would never be called, then the
internal checking logic in `ResultPartitionManager#onConsumedPartition` seems
reductant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
