JingsongLi commented on a change in pull request #8682:
[FLINK-12796][table-planner-blink] Introduce BaseArray and BaseMap to reduce
conversion overhead to blink
URL: https://github.com/apache/flink/pull/8682#discussion_r292730302
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryMap.java
##########
@@ -69,6 +74,18 @@ public BinaryArray valueArray() {
return values;
}
+ @Override
+ public Map<Object, Object> toJavaMap(LogicalType keyType, LogicalType
valueType) {
+ Object[] keyArray = keys.toClassArray(keyType,
getInternalClassForType(keyType));
+ Object[] valueArray = values.toClassArray(keyType,
getInternalClassForType(valueType));
Review comment:
nice catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
