wuchong commented on a change in pull request #8678: [FLINK-12708][table] 
Introduce new source and sink interfaces to make Blink runner work
URL: https://github.com/apache/flink/pull/8678#discussion_r292728154
 
 

 ##########
 File path: 
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/StreamTableEnvImpl.scala
 ##########
 @@ -93,6 +93,10 @@ abstract class StreamTableEnvImpl(
                 s"environment. But is: ${execEnv.getStreamTimeCharacteristic}")
         }
 
+      case streamTableSource: StreamTableSource[_] if 
streamTableSource.isBounded =>
 
 Review comment:
   I think it's a protection. If users declares a TableSource is bounded, he 
may want a batch source which shouldn't be registered into StreamTableEnv. In 
other word, this check is in order to prohibit to register a 
`BoundedTableSource`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to