zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r291896474
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java
##########
@@ -122,6 +126,10 @@ public boolean isNetworkDetailedMetrics() {
return isNetworkDetailedMetrics;
}
+ public boolean isReleaseExternallyManagedPartitionsOnConsumption() {
Review comment:
May be better to unify the method with variable name.
`isReleasePartititionsOnConsumption|
isReleaseBlockingPartitionsOnConsumption|
isReleaseExternallyManagedPartitionsOnConsumption`
IMO `isReleasePartititionsOnConsumption` might be simple and proper, no need
to concern on whether it is blocking or external.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
