[
https://issues.apache.org/jira/browse/FLINK-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857451#comment-16857451
]
Andrey Zagrebin commented on FLINK-12555:
-----------------------------------------
merged into master
commit: e64d070873eb53aa089d1ad318cdb755f084fa66
> Introduce an encapsulated metric group layout for shuffle API and deprecate
> old one
> -----------------------------------------------------------------------------------
>
> Key: FLINK-12555
> URL: https://issues.apache.org/jira/browse/FLINK-12555
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Network
> Reporter: Andrey Zagrebin
> Assignee: Andrey Zagrebin
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.9.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> At the moment, partition/gate create methods in NetworkEnvironment have a lot
> of metrics arguments to maintain original layout for metric groups. This
> approach is not quite encapsulated and clean for shuffle API. We can have
> just one parent group for shuffle metrics. The old layout can be still
> maintained in parallel and deprecated. At the moment we can do it with a
> couple of casts (if shuffle implementation is NetworkEnvironment) and adding
> an additional legacy metric registration which can be removed later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
