zhijiangW commented on issue #8529: [FLINK-12603][network] Refactor InputGate 
interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529#issuecomment-496776930
 
 
   Thanks for the reviews and good suggestions @azagrebin !
   
   Yes, we still rely on some network options in `BarrierBuffer` 
implementation. And I also think it is not good to do so. This PR is mainly 
making the interface seem more general and clean. We could further refactor the 
`BarrierBuffer` implementation future as I suggested inline comments. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to