zhijiangW commented on a change in pull request #8529: [FLINK-12603][network]
Refactor InputGate interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529#discussion_r288375567
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/InputProcessorUtil.java
##########
@@ -53,12 +54,13 @@ public static CheckpointBarrierHandler
createCheckpointBarrierHandler(
+ " must be positive or -1 (infinite)");
}
+ int pageSize =
NetworkEnvironmentConfiguration.getPageSize(taskManagerConfig);
Review comment:
Thanks for this good catch.
The options of page size and `NETWORK_CREDIT_MODEL` might be not general for
all shuffle services. `BarrierHandler` should not concern of the specific
shuffle service implementation and see these parameters in theory.
Actually the `NETWORK_CREDIT_MODEL` option is deprecated. If we could remove
this option completed and the page size is also not needed because
`CachedBufferBlocker` could get the page size from `BufferOrEvent#getSize`
after introducing the `InputGateWithMetrics` in another PR.
There was a blocker for removing these deprecated codes before, but I think
this blocker is already confirmed now. Then I would talk with Piotr about when
to remove them (would be better if done in release 1.9). I think this is a
right way to go to avoid extra efforts of abstracting `BarrierBuffer` creation.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
