[
https://issues.apache.org/jira/browse/FLINK-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850022#comment-16850022
]
Fabian Wollert edited comment on FLINK-10707 at 5/28/19 6:46 PM:
-----------------------------------------------------------------
[~rmetzger] okay, i got the code now to show what i wanted:
!image-2019-05-28-20-38-00-761.png|width=800,height=280!
BUT: due to my lack of knowledge in regards to Angular, i had to hack things
together. Things which immediately come to my mind which need especially review:
-
https://github.com/apache/flink/pull/8542/files#diff-81d17e6833d6e23b2c41ad4daaa2e6c7R39
- putting a number in the interface, although its getting computed later only,
not coming from the API
- hardcoding font colors
[here|https://github.com/apache/flink/pull/8542/files#diff-39dabf2440b3769ed1956c9b26079b7eR25]
and
[here|https://github.com/apache/flink/pull/8542/files#diff-39dabf2440b3769ed1956c9b26079b7eR91]
- this tooltip refreshes all the time the dashboard pulls new data:
https://github.com/apache/flink/pull/8542/files#diff-39dabf2440b3769ed1956c9b26079b7eR93
- using deprecated {{::ng-deep}}
[here|https://github.com/apache/flink/pull/8542/files#diff-3e0e4952ed8eda1bec7d30d46120d452R54]
- this whole file:
flink-runtime-web/web-dashboard/src/app/pages/overview/statistic/overview-statistic.component.ts
I think this can be done better code wise. Maybe someone with more Angular
Experience can go over this ([~vthinkxie] maybe?) and advise how to do this
best.
Nevertheless it works, and you can check out the code and the dashboard, if
those changes make sense to show, or if they just clutter the UI. Feedback is
highly appreciated!
was (Author: wolli):
okay, i got the code now to show what i wanted:
!image-2019-05-28-20-38-00-761.png|width=800,height=280!
> Improve Cluster Overview in Flink Dashboard
> -------------------------------------------
>
> Key: FLINK-10707
> URL: https://issues.apache.org/jira/browse/FLINK-10707
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Web Frontend
> Reporter: Fabian Wollert
> Assignee: Fabian Wollert
> Priority: Major
> Labels: pull-request-available
> Attachments: flink-dashboard.png, image-2019-05-28-20-38-00-761.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The flink Dashboard is currently very simple. The following screenshot is a
> mock of an improvement proposal:
> !flink-dashboard.png|width=806,height=401!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
