KurtYoung commented on a change in pull request #8536: [FLINK-12568][hive]
Implement TableSink and OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#discussion_r287723810
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -53,7 +53,21 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-table-api-java</artifactId>
+
<artifactId>flink-hadoop-compatibility_${scala.binary.version}</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
Review comment:
I think it's also not a good idea since we are deprecating `DataSet` now.
How about:
1. Decouple the implementation details for this functionality and first
merge the parts which unrelated to TableSink interface, like provide an
OutputFormat and test it independently.
2. Provide the TableSink implementation after we decide and merge the
TableSink interface into `common` or `api` package, and add some integration
tests with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
