yanghua commented on a change in pull request #8322: [FLINK-12364] Introduce a
CheckpointFailureManager to centralized manage checkpoint failure
URL: https://github.com/apache/flink/pull/8322#discussion_r287661884
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -540,14 +531,13 @@ public void enableCheckpointing(
checkpointStatsTracker = checkNotNull(statsTracker,
"CheckpointStatsTracker");
+ CheckpointFailureManager failureManager = new
CheckpointFailureManager(chkConfig.getTolerableCheckpointFailureNumber(), () ->
+ failGlobal(new FlinkRuntimeException("Exceeded
checkpoint tolerable failure threshold.")));
Review comment:
Hi @StefanRRichter and @tillrohrmann ping for help, I suspect that this call
will cause a deadlock with [this
check](https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L1196).
WDYT? Any opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
