lirui-apache commented on a change in pull request #8536: [FLINK-12568][hive] 
Implement TableSink and OutputFormat to write Hive tables
URL: https://github.com/apache/flink/pull/8536#discussion_r287633298
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
 ##########
 @@ -590,6 +578,17 @@ private  static Table instantiateHiveTable(ObjectPath 
tablePath, CatalogBaseTabl
                return hiveTable;
        }
 
+       private static void setStorageFormat(StorageDescriptor sd, Map<String, 
String> properties) {
+               // TODO: simply use text format for now
+               String storageFormatName = DEFAULT_HIVE_TABLE_STORAGE_FORMAT;
+               StorageFormatDescriptor sfDescriptor = 
storageFormatFactory.get(storageFormatName);
+               checkArgument(sfDescriptor != null, "Unknown storage format " + 
storageFormatName);
 
 Review comment:
   It doesn't directly check input argument. It checks whether we can get a 
StorageFormatDescriptor based on the input argument.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to