Aitozi commented on a change in pull request #8467: [FLINK-12535][network] Make
CheckpointBarrierHandler non-blocking
URL: https://github.com/apache/flink/pull/8467#discussion_r287607135
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java
##########
@@ -112,6 +113,8 @@
/** Flag to indicate whether we have drawn all available input. */
private boolean endOfStream;
+ private boolean isFinished;
Review comment:
No comment for this field, I think this should be comment because it has a
different behavior with `BufferTracker.java` about `finish`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
