hequn8128 opened a new pull request #8508: [FLINK-12533][table] Introduce TABLE_AGGREGATE_FUNCTION FunctionDefinition.Type URL: https://github.com/apache/flink/pull/8508 ## What is the purpose of the change This pull request adds TABLE_AGGREGATE_FUNCTION FunctionDefinition.Type. Currently, there are four kinds of FunctionDefinition.Type, ``` public enum Type { AGGREGATE_FUNCTION, SCALAR_FUNCTION, TABLE_FUNCTION, OTHER_FUNCTION } ``` The Type AGGREGATE_FUNCTION is used to express both AggregateFunction and TableAggregateFunction. However, due to the two kinds of the function contains different semantics. It would be nice if we can separate these two kinds of functions more clearly by introducing another type TABLE_AGGREGATE_FUNCTION. ## Brief change log - Add `TABLE_AGGREGATE_FUNCTION` and use `TABLE_AGGREGATE_FUNCTION` for user defined table aggregate function in `AggregateFunctionDefinition`. - Use `TABLE_AGGREGATE_FUNCTION` to judge whether it is table aggregate in `AggregateOperationFactory` and `TableOperationConverter`. - Add tests for FunctionDefinition. ## Verifying this change This change is already covered by existing tests, such as `TableAggregateTest`, `TableAggregateValidationTest` and `TableAggregateITCase`. Also `FunctionDefinitionTest` has been added to test the new `getFunctionType` function in `FunctionDefinition`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
