klion26 commented on a change in pull request #8479: [FLINK-11193][State 
Backends]Use user passed configuration overriding default configuration loading 
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r286323947
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -295,6 +297,7 @@ public RocksDBStateBackend(AbstractStateBackend 
checkpointStreamBackend, boolean
         * @param classLoader The class loader.
         */
        private RocksDBStateBackend(RocksDBStateBackend original, Configuration 
config, ClassLoader classLoader) {
+               this.configuration = config;
 
 Review comment:
   But the code below(start from line 302) seems to use the **original 
backend's** conf first, so I'm not sure you change now is on the right 
directory(maybe the change you've made can't solve the problem on the issue)? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to