[
https://issues.apache.org/jira/browse/FLINK-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845520#comment-16845520
]
vinoyang edited comment on FLINK-8871 at 5/22/19 4:58 AM:
----------------------------------------------------------
[~carp84] Ok, I will reply directly to your question for the following reasons:
* His solution (also proposed by us) is now meaningless, I just gave my
advice. If it makes sense, I have already raised it. I just made a friendly
suggestion and don’t want to waste his time. If his plan still applies after so
many follow-up works, then this is my fault, But no doubt, the answer is no.
* I am involved in related work, they will more directly affect the solution
and design of this issue;
* I have already claimed two other issues that are almost identical to it, and
I expect them to be consistent.
I hope this explanation is clear enough.
I admit that I should give [~yunta] more explanation before I make a decision.
was (Author: yanghua):
[~carp84] Ok, I will reply directly to your question for the following reasons:
* His solution (also proposed by us) is now meaningless, I just gave my
advice. If it makes sense, I have already raised it. I just made a friendly
suggestion and don’t want to waste his time. If his plan still applies after so
many follow-up works, then this is my fault.
* I am involved in related work, they will more directly affect the solution
and design of this issue;
* I have already claimed two other issues that are almost identical to it, and
I expect them to be consistent.
I hope this explanation is clear enough.
I admit that I should give [~yunta] more explanation before I make a decision.
> Checkpoint cancellation is not propagated to stop checkpointing threads on
> the task manager
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-8871
> URL: https://issues.apache.org/jira/browse/FLINK-8871
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Affects Versions: 1.3.2, 1.4.1, 1.5.0, 1.6.0, 1.7.0
> Reporter: Stefan Richter
> Assignee: vinoyang
> Priority: Critical
>
> Flink currently lacks any form of feedback mechanism from the job manager /
> checkpoint coordinator to the tasks when it comes to failing a checkpoint.
> This means that running snapshots on the tasks are also not stopped even if
> their owning checkpoint is already cancelled. Two examples for cases where
> this applies are checkpoint timeouts and local checkpoint failures on a task
> together with a configuration that does not fail tasks on checkpoint failure.
> Notice that those running snapshots do no longer account for the maximum
> number of parallel checkpoints, because their owning checkpoint is considered
> as cancelled.
> Not stopping the task's snapshot thread can lead to a problematic situation
> where the next checkpoints already started, while the abandoned checkpoint
> thread from a previous checkpoint is still lingering around running. This
> scenario can potentially cascade: many parallel checkpoints will slow down
> checkpointing and make timeouts even more likely.
>
> A possible solution is introducing a {{cancelCheckpoint}} method as
> counterpart to the {{triggerCheckpoint}} method in the task manager gateway,
> which is invoked by the checkpoint coordinator as part of cancelling the
> checkpoint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
