bowenli86 commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286304895
########## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogTestBase.java ########## @@ -716,4 +1091,8 @@ protected void checkEquals(CatalogView v1, CatalogView v2) { assertEquals(v1.getOriginalQuery(), v2.getOriginalQuery()); assertEquals(v1.getExpandedQuery(), v2.getExpandedQuery()); } + + protected void checkEquals(CatalogPartition expected, CatalogPartition actual) { + assertEquals(expected.getProperties(), actual.getProperties()); Review comment: oh, then probably don't need to do so, we don't check descriptions so far yet ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services