lirui-apache commented on a change in pull request #8449: [FLINK-12235][hive] Support partition related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8449#discussion_r286298510
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java ########## @@ -492,15 +484,12 @@ public void alterPartition(ObjectPath tablePath, CatalogPartitionSpec partitionS checkNotNull(tablePath); checkNotNull(partitionSpec); - if (!tableExists(tablePath)) { Review comment: We don't have to. Because the following call to getTable will take care of that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services