liyafan82 commented on issue #8278: [FLINK-12335][Table-runtime]Improvement the performance of class SegmentsUtil URL: https://github.com/apache/flink/pull/8278#issuecomment-494286726 > Thanks @liyafan82 for you code, maybe you can change the title to `remove useless code in SegmentsUtil`, I think the jdk/jvm will optimizer it, so maybe performance keep same. Thanks for your comments. I have made some investigations to analyze the assembly generated by JIT. It seems that JIT successfully removes BIT_BYTE_POSITION_MASK, but fails to remove BIT_BYTE_INDEX_MASK. So there can be performance overhead. 
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
