xuefuz commented on a change in pull request #8404: [FLINK-11476][table] Create CatalogManager to manage multiple catalogs URL: https://github.com/apache/flink/pull/8404#discussion_r284923963
########## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableConfig.java ########## @@ -57,6 +57,18 @@ */ private Integer maxGeneratedCodeLength = 64000; // just an estimate + /** + * Specifies the name of the initial catalog to be created when instantiating + * TableEnvironment. + */ + private String bultinCatalogName = "default-catalog"; + + /** + * Specifies the name of the default database in the initial catalog to be created when instantiating + * TableEnvironment. + */ + private String bultinDatabaseName = "default-database"; Review comment: Having '-' in the names might confuse the parser as it can be read as a numeric minus operation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services