bowenli86 commented on a change in pull request #8449: [FLINK-12235][hive]
Support partition related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8449#discussion_r284860471
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
##########
@@ -412,31 +418,22 @@ public void createPartition(ObjectPath tablePath,
CatalogPartitionSpec partition
checkNotNull(partitionSpec);
checkNotNull(partition);
- if (!tableExists(tablePath)) {
Review comment:
I think it may not worth extract these to their own methods like
`ensureTableExists` since it's such a simple logic and very clear to readers
what happens. When I read this code now, I have to find and check where the
`ensureXxx` are and what they do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
