[ 
https://issues.apache.org/jira/browse/FLINK-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840166#comment-16840166
 ] 

shuai.xu edited comment on FLINK-12372 at 5/16/19 2:56 AM:
-----------------------------------------------------------

Hi [~gjy]

For the ScheduleUnit, I think your proposal works.

For the getPreferredLocationsBasedOnInputs, I think we can put it in the 
implementation of ExecutionSlotAllocator. But this is an expediency, it need to 
be refined later.

And do we need to change the 

cancel(SlotExecutionVertexAssignment) in ExecutionSlotAllcator to 
cancel(ExecutionVertexID), as Scheduler may need to call this method when reset 
the ExeuctionVertex, but it doesn't know the SlotExecutionVertexAssignment, it 
only know ExeuctionVertexID.


was (Author: tiemsn):
Hi [~gjy]

For the ScheduleUnit, I think your proposal works.

For the getPreferredLocationsBasedOnInputs, I think we can put it in the 
implementation of ExecutionSlotAllocator. But this is an expediency, it need to 
be refined later.

> Implement ExecutionSlotAllocator
> --------------------------------
>
>                 Key: FLINK-12372
>                 URL: https://issues.apache.org/jira/browse/FLINK-12372
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>            Reporter: Gary Yao
>            Assignee: shuai.xu
>            Priority: Major
>
> Add and implement {{ExecutionSlotAllocator}} interface
> Design document: 
> https://docs.google.com/document/d/1fstkML72YBO1tGD_dmG2rwvd9bklhRVauh4FSsDDwXU
> *Acceptance criteria*
> * {{ExecutionSlotAllocator}} interface is defined and implemented
> * interface implementation is unit tested



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to