danny0405 commented on a change in pull request #8324: [FLINK-11921][table]
Upgrade to calcite 1.19
URL: https://github.com/apache/flink/pull/8324#discussion_r284092067
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
##########
@@ -1039,6 +1141,46 @@ public String getFraction() {
return fraction;
}
}
+
+ /** Deals with values of {@code java.time.OffsetDateTime} without
introducing
+ * a compile-time dependency (because {@code OffsetDateTime} is only
JDK 8 and
+ * higher). */
+ private interface OffsetDateTimeHandler {
+ boolean isOffsetDateTime(Object o);
+ String stringValue(Object o);
Review comment:
Do we really need this interface `stringValue` ? The two implementations:
one is static and one throws an exception, i didn't see why we should keep this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
