WeiZhong94 commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283776634
########## File path: flink-python/pyflink/table/query_config.py ########## @@ -0,0 +1,108 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ +from abc import ABCMeta +from datetime import timedelta +from py4j.compat import long + +from pyflink.java_gateway import get_gateway + + +class QueryConfig(object): + """ + The :class:`QueryConfig` holds parameters to configure the behavior of queries. + """ + + __metaclass__ = ABCMeta + + def __init__(self, j_query_config): + self._j_query_config = j_query_config + + +class StreamQueryConfig(QueryConfig): + """ + The :class:`StreamQueryConfig` holds parameters to configure the behavior of streaming queries. + """ + + def __init__(self, j_stream_query_config=None): + self._jvm = get_gateway().jvm + if j_stream_query_config is not None: + self._j_stream_query_config = j_stream_query_config + else: + self._j_stream_query_config = self._jvm.StreamQueryConfig() + super(StreamQueryConfig, self).__init__(self._j_stream_query_config) + + def with_idle_state_retention_time(self, min_time, max_time): Review comment: I have adjust the doc of this method in the new commit. Now it is more clear. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
