bowenli86 commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r283595220
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/TableEnvImpl.scala
##########
@@ -69,45 +66,19 @@ import _root_.scala.collection.mutable
*/
abstract class TableEnvImpl(val config: TableConfig) extends TableEnvironment {
- // the catalog to hold all registered and translated tables
- // we disable caching here to prevent side effects
- private val internalSchema: CalciteSchema =
CalciteSchema.createRootSchema(false, false)
- private val rootSchema: SchemaPlus = internalSchema.plus()
-
// Table API/SQL function catalog
private[flink] val functionCatalog: FunctionCatalog = new FunctionCatalog()
- // the configuration to create a Calcite planner
- private lazy val frameworkConfig: FrameworkConfig = Frameworks
- .newConfigBuilder
- .defaultSchema(rootSchema)
- .parserConfig(getSqlParserConfig)
- .costFactory(new DataSetCostFactory)
- .typeSystem(new FlinkTypeSystem)
- .operatorTable(getSqlOperatorTable)
- .sqlToRelConverterConfig(getSqlToRelConverterConfig)
- // the converter is needed when calling temporal table functions from SQL,
because
- // they reference a history table represented with a tree of table
operations
- .context(Contexts.of(
- new TableOperationConverter.ToRelConverterSupplier(expressionBridge)
- ))
- // set the executor to evaluate constant expressions
- .executor(new ExpressionReducer(config))
- .build
+ private val BUILTIN_CATALOG_NAME = "builtin"
Review comment:
does TableEnvironment need to know the default catalog's name in
CatalogManager?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
