sunjincheng121 commented on issue #8392: [FLINK-12370][python][travis] 
Integrated Travis for Python Table API.
URL: https://github.com/apache/flink/pull/8392#issuecomment-492027462
 
 
   We have two options for Python integration with Travis. 
   
   1. It is the addition of a python stage that PR currently reflects. Instead 
of using MVN for testing, it runs a separate shell.
   2. Using MVN to execute the shell, Python validation is also MVN is tested. 
I personally prefer the current PR program. The reason is that:
         - The Python API is a different language from Java/Scala. The code 
management and testing methods are not dependent on MVN. Python multi-version 
and Python API functional tests are combined using Conda and Tox. So we choose 
not to use the MVN solution;
   
        - The Python API is a new language API that has just been incorporated 
into Flink. We would like to have an intuitive understanding of Python's 
details in the Travis process and intuitively observe the time spent testing 
the Python API. So choose a separate stage and a separate run output solution.
   
   Of course, there are 2 aspects, 1. Independent stage 2. Is it integrated 
into MVN, that is, 2x2=4 options, I tend to the current PR.
   
   What do you think? @aljoscha @zentol 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to