xuefuz commented on a change in pull request #8353: [FLINK-12233][hive] Support
table related operations in HiveCatalog
URL: https://github.com/apache/flink/pull/8353#discussion_r283461610
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogBase.java
##########
@@ -89,6 +96,34 @@ private static IMetaStoreClient getMetastoreClient(HiveConf
hiveConf) {
}
}
+ // ------ APIs ------
+
+ /**
+ * Validate input base table.
+ *
+ * @param catalogBaseTable the base table to be validated
+ * @throws CatalogException thrown if the input base table is invalid.
+ */
+ protected abstract void validateCatalogBaseTable(CatalogBaseTable
catalogBaseTable)
+ throws CatalogException;
+
+ /**
+ * Create a CatalogBaseTable from a Hive table.
+ *
+ * @param hiveTable a Hive table
+ * @return a CatalogBaseTable
+ */
+ protected abstract CatalogBaseTable createCatalogBaseTable(Table
hiveTable);
Review comment:
I think we can just name the method createCatalogTable() which sounds more
general, and as a direct counterpart of createHiveTable(). However, this is
very minor though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
