yanghua commented on a change in pull request #8410: [FLINK-11159] Allow
configuration whether to fall back to savepoints for restore
URL: https://github.com/apache/flink/pull/8410#discussion_r283314002
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java
##########
@@ -77,8 +79,32 @@ public void addCheckpoint(CompletedCheckpoint checkpoint)
throws Exception {
}
@Override
- public CompletedCheckpoint getLatestCheckpoint() {
- return checkpoints.isEmpty() ? null : checkpoints.getLast();
+ public CompletedCheckpoint getLatestCheckpoint(boolean
isPreferCheckpointForRecovery) {
+ if (checkpoints.isEmpty()) {
+ return null;
+ }
+
+ CompletedCheckpoint candidate = checkpoints.getLast();
Review comment:
Agree, actually, I found the similar code snippet when I was implementing.
The difference between the original implementation of the `getLatestCheckpoint`
is the usage of `peekLast` and `getLast`. I was afraid to destroy the original
semantics. If it does not matter, I'd like to do this refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
