Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle 
the wrapped function
URL: https://github.com/apache/flink/pull/8280#issuecomment-491563946
 
 
   Hi, @StephanEwen 
   I have followed your suggestion to add some fix. Still two have to confim:
   1. check at the top level with the condition you mentioned may skip some 
class wrong, think about a  class has no enclosingClass it may also have to be 
cleaned, so i don't add the check.
   2. I found that the scala class clean is working with 
`ClosureCleaner.scala`. I think it should be consistent with the java clean 
action. I am not quiet familiar with the scala, but i will try to look into it. 
  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to