StephanEwen commented on issue #8290: [FLINK-12070] [network] Implement new bounded blocking subpartitions URL: https://github.com/apache/flink/pull/8290#issuecomment-491372403 Thank you for the reviews. I refactored some code: - Pulled out the `MemoryMappedBuffers`) class to better test `size()` and region spanning writes and avoid leaking the region configuration into the `BoundedBlockingSubpartition`. - Added comments to make the treading model assumptions more clear - Addressed comments on typos, etc. The code staged to be merged is in https://github.com/StephanEwen/incubator-flink/commit/a7cf24383be9f310fb5ccc5a032721421fa45791 I think overall, this is now in a really good shape. Waiting for Travis to pass, will then merge this. Followups are to to actually make use of the "multiple read" functionality.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
